Skip to content

gh-129223: Raise KeyError in search_map_for_section() if not found #129262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2025
Merged

gh-129223: Raise KeyError in search_map_for_section() if not found #129262

merged 2 commits into from
Jan 25, 2025

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jan 24, 2025 •
edited by bedevere-app bot
Loading

@vstinner vstinner self-assigned this Jan 24, 2025
@bedevere-app bedevere-app bot added awaiting core review tests Tests in the Lib/test dir labels Jan 24, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jan 24, 2025
Closed
@vstinner vstinner force-pushed the search_map_for_section branch from 266eeee to c8c5241 Compare January 24, 2025 13:49
@vstinner
Copy link
Member Author

@pablogsal @ambv @encukou: This change fix the SystemError in test_external_inspection on Fedora Stable with LTO.

@vstinner vstinner mentioned this pull request Jan 24, 2025
Merged
6 tasks
@ambv
Copy link
Contributor

ambv commented Jan 24, 2025

I'm not crazy about this approach because silently skipping tests when we couldn't find a section on a platform that we expected to be able to find the section is a bug. The fix in #129225 actually addresses the problem, which was the compiler optimizing away debug sections unless __attribute__((used)) was used.

@vstinner
Copy link
Member Author

I can modify my PR to not skip the tests on KeyError.

@pablogsal
Copy link
Member

I can modify my PR to not skip the tests on KeyError.

This should be fixed by the real fix #129225. Please, let's remove the skips because that will be masking actual errors that we want to fix. Let's merge the PR with the new raising of KeyError 👍

@vstinner
Copy link
Member Author

@ambv @pablogsal: Ok, I modified my PR only to fix the SystemError, tests are no longer skipped.

@ambv ambv merged commit be98fda into python:main Jan 25, 2025
40 checks passed
@vstinner vstinner deleted the search_map_for_section branch January 25, 2025 20:12
@sergey-miryanov sergey-miryanov mentioned this pull request Feb 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vstinner vstinner

Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @ambv @pablogsal