Improve tests for _colorize.can_colorize() #129234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
tests
hugovk
approved these changes
Jan 24, 2025
| import sys | ||
| import unittest | ||
| import unittest.mock | ||
| import _colorize | ||
| from test.support import force_not_colorized, make_clean_env |
There was a problem hiding this comment.
make_clean_env was moved to test.support from the PyREPL tests for use in this file (in #127877).
If we're not using it here any more, should we move it back, or leave it in case it's useful for others later?
There was a problem hiding this comment.
I do not know. I tried to use make_clean_env(), but we need to remove also NO_COLOR. On other hand, the only PYTHON* variable that needs to be removed is PYTHON_COLORS. Let it be there for now, and then we'll see.
Co-authored-by: Hugo van Kemenade <[email protected]>
|
Thanks @serhiy-storchaka for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 24, 2025
(cherry picked from commit 7907203) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
|
GH-129265 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jan 24, 2025
) (cherry picked from commit 7907203) Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.