gh-111178: fix UBSan failures in Modules/_ssl/cert.c
#129088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
picnixz
commented
Jan 20, 2025
•
picnixz
commented
- Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
encukou
reviewed
Jan 27, 2025
| Py_RETURN_NOTIMPLEMENTED; | ||
| } | ||
| /* only support == and != */ | ||
| if ((op != Py_EQ) && (op != Py_NE)) { | ||
| Py_RETURN_NOTIMPLEMENTED; | ||
| } | ||
| cmp = X509_cmp(self->cert, ((PySSLCertificate*)other)->cert); | ||
| cmp = X509_cmp(self->cert, ((PySSLCertificate*)rhs)->cert); |
There was a problem hiding this comment.
Suggested change
| cmp = X509_cmp(self->cert, ((PySSLCertificate*)rhs)->cert); | |
| cmp = X509_cmp(self->cert, _PySSLCertificate_CAST(rhs)->cert); |
There was a problem hiding this comment.
I've left out fast casts for which the input has already been checked so that if the macro is one day converted to a function with explicit checks, we don't double checks those
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
…H-129088) fix UBSan failures for `PySSLCertificate`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.