-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-128519: Update the docstring of untokenize()
to match the docs
#128521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstring previously claimed full roundtrip invariance, which is not the case.
Misc/NEWS.d/next/Library/2025-01-05-18-41-27.gh-issue-128519.DfI2M2.rst
Outdated
Show resolved
Hide resolved
erlend-aasland
approved these changes
Jan 6, 2025
FTR, doc amendments are normally backported to all active branches. |
This comment was marked as outdated.
This comment was marked as outdated.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2025
pythonGH-128521) (cherry picked from commit aef52ca) Co-authored-by: Tomas R. <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 6, 2025
pythonGH-128521) (cherry picked from commit aef52ca) Co-authored-by: Tomas R. <[email protected]>
GH-128531 is a backport of this pull request to the 3.13 branch. |
GH-128532 is a backport of this pull request to the 3.12 branch. |
erlend-aasland
pushed a commit
that referenced
this pull request
Jan 6, 2025
…cs (GH-128521) (#128532) (cherry picked from commit aef52ca) Co-authored-by: Tomas R <[email protected]>
erlend-aasland
pushed a commit
that referenced
this pull request
Jan 6, 2025
…cs (GH-128521) (#128531) (cherry picked from commit aef52ca) Co-authored-by: Tomas R <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks! I wanted to add the backport labels but you beat me to it 😄 |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Synchronizes the docstring of
untokenize
with the docs regarding roundtrip invariance guarantees.See the linked issue for details :)
untokenize()
to match the docs #128519