Skip to content

gh-128519: Update the docstring of untokenize() to match the docs #128521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

tomasr8
Copy link
Member

@tomasr8 tomasr8 commented Jan 5, 2025

Synchronizes the docstring of untokenize with the docs regarding roundtrip invariance guarantees.
See the linked issue for details :)

The docstring previously claimed full roundtrip invariance,
which is not the case.
@erlend-aasland erlend-aasland enabled auto-merge (squash) January 6, 2025 08:24
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Jan 6, 2025
@erlend-aasland
Copy link
Contributor

FTR, doc amendments are normally backported to all active branches.

@erlend-aasland erlend-aasland merged commit aef52ca into python:main Jan 6, 2025
44 of 46 checks passed
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2025

GH-128531 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jan 6, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2025

GH-128532 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jan 6, 2025
erlend-aasland pushed a commit that referenced this pull request Jan 6, 2025
erlend-aasland pushed a commit that referenced this pull request Jan 6, 2025
@bedevere-bot

This comment was marked as off-topic.

@tomasr8 tomasr8 deleted the untokenize-docstring branch January 6, 2025 10:31
@tomasr8
Copy link
Member Author

tomasr8 commented Jan 6, 2025

FTR, doc amendments are normally backported to all active branches.

Thanks! I wanted to add the backport labels but you beat me to it 😄

srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants