gh-128345: GIL is not properly disabled for _freeze_module.vcxproj

[TheShermanTanker]

The _freeze_module.vcxproj file is looking for #undef Py_GIL_DISABLED, but that was changed to /* #define Py_GIL_DISABLED 1 */ some time ago, so the build system ends up looking to replace a line that doesn't exist, the result is that the freeze Python never has GIL disabled even if it was requested during the build

• Issue: GIL is not properly disabled for _freeze_module.vcxproj #128345

[rruuaanng]

cc @ZeroIntensity

[ZeroIntensity]

Are we able to add some sort of test?

[zooba]

It hardly matters for this tool.

If it's somehow going to help the people working on free-threading to have it enabled for a build time tool, then sure. But there's no reason to backport it. Nobody is developing free-threading in 3.13 anymore - they're all working in main.

[ZeroIntensity]

Thanks for the clarification, LGTM.

[colesbury]

LGTM as well

[colesbury]

!buildbot nogil windows

[bedevere-bot]

The regex 'nogil windows' did not match any buildbot builder. Is the requested builder in the list of stable builders?

[colesbury]

!buildbot windows nogil

[bedevere-bot]

The regex 'windows nogil' did not match any buildbot builder. Is the requested builder in the list of stable builders?

[colesbury]

!buildbot nogil

[bedevere-bot]

🤖 New build scheduled with the buildbot fleet by @colesbury for commit cf12bef 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

• AMD64 Windows Server 2022 NoGIL PR
• AMD64 Fedora Rawhide NoGIL refleaks PR
• AMD64 CentOS9 NoGIL Refleaks PR
• x86-64 MacOS Intel ASAN NoGIL PR
• AMD64 Windows PGO NoGIL PR
• aarch64 Fedora Rawhide NoGIL PR
• PPC64LE Fedora Rawhide NoGIL refleaks PR
• aarch64 Fedora Rawhide NoGIL refleaks PR
• ARM64 MacOS M1 NoGIL PR
• AMD64 CentOS9 NoGIL PR
• ARM64 MacOS M1 Refleaks NoGIL PR
• AMD64 Fedora Rawhide NoGIL PR
• PPC64LE Fedora Rawhide NoGIL PR
• x86-64 MacOS Intel NoGIL PR