Skip to content

bpo-31904: remove _crypt extension for VxWorks RTOS #12833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 15, 2019
Merged

bpo-31904: remove _crypt extension for VxWorks RTOS #12833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6cee566
adapt _crypt module to VxWorks
pxinwr Mar 14, 2019
416d1ac
add news file
pxinwr Mar 14, 2019
2adde84
Macro crypt to DES_crypt on VxWorks
pxinwr Mar 15, 2019
e41a5ee
remove crypt module support for VxWorks
pxinwr Apr 1, 2019
4a1dbe1
rephrase VxWorks not supporting crypt module
pxinwr Apr 15, 2019
5e06e8c
mv and modidy NEWS file
pxinwr Apr 15, 2019
bc13280
exclude crypt extension in detect_crypt() rather than detect_modules()
pxinwr Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Doc/library/crypt.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ the :manpage:`crypt(3)` routine in the running system. Therefore, any
extensions available on the current implementation will also be available on
this module.

.. availability:: Unix. Not available on VxWorks.

Hashing Methods
---------------

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Build/2019-04-15-15-01-29.bpo-31904.38fdkg.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Don't build the ``_crypt`` extension on VxWorks.
13 changes: 7 additions & 6 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,17 +975,18 @@ def detect_readline_curses(self):

def detect_crypt(self):
# crypt module.
if VXWORKS:
# bpo-31904: crypt() function is not provided by VxWorks.
# DES_crypt() OpenSSL provides is too weak to implement
# the encryption.
return

if self.compiler.find_library_file(self.lib_dirs, 'crypt'):
libs = ['crypt']
else:
libs = []

if not VXWORKS:
self.add(Extension('_crypt', ['_cryptmodule.c'],
libraries=libs))
elif self.compiler.find_library_file(self.lib_dirs, 'OPENSSL'):
libs = ['OPENSSL']
self.add(Extension('_crypt', ['_cryptmodule.c'],
self.add(Extension('_crypt', ['_cryptmodule.c'],
libraries=libs))

def detect_socket(self):
Expand Down