gh-127488: Add tests for Tools/i18n/msgfmt.py
#127540
Conversation
|
I'll fix the Windows failures in a bit (it's just about normalizing newlines) |
|
cc @serhiy-storchaka if you'd like having a look :) |
erlend-aasland
requested review from
serhiy-storchaka
and removed request for
erlend-aasland
|
Thanks for the review! I addressed both of your comments :) |
|
Friendly reminder 🙂 @serhiy-storchaka |
serhiy-storchaka
added
needs backport to 3.12
|
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
(cherry picked from commit 361083b) Co-authored-by: Tomas R. <[email protected]>
|
GH-130181 is a backport of this pull request to the 3.12 branch. |
(cherry picked from commit 361083b) Co-authored-by: Tomas R. <[email protected]>
|
GH-130182 is a backport of this pull request to the 3.13 branch. |
…130181) (cherry picked from commit 361083b) Co-authored-by: Tomas R <[email protected]>
…130182) (cherry picked from commit 361083b) Co-authored-by: Tomas R <[email protected]>
terryjreedy
removed
needs backport to 3.12
|
@hugovk One of the bots should have removed the backport labels after making the backports. The other obsolete labels I have removed involved the bpo-gh move or manual backports or some additional bot malfunction, whereas this has the 'is a backport' labels and otherwise looks normal. |
Adds tests for both the compilation itself and the CLI.
One thing I'm not so sure is about is keeping the binary MO file checked in git.
They are not compared byte by byte, instead I compare the parsed catalog files.
The catalogs could be saved in a human-readable format like JSON for example.
cc @srinivasreddy
Tools/i18n/msgfmt.py#127488