Skip to content

[3.7] bpo-36560: regrtest: don't collect the GC twice (GH-12747) #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2019
Merged

[3.7] bpo-36560: regrtest: don't collect the GC twice (GH-12747) #12749

merged 2 commits into from
Apr 9, 2019

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 9, 2019 •
edited by bedevere-bot
Loading

vstinner added 2 commits April 9, 2019 18:27
@vstinner
bpo-36560: Fix reference leak hunting in regrtest (GH-12744)
3f3489c 
Fix reference leak hunting in regrtest: compute also deltas (of
reference count, allocated memory blocks, file descriptor count)
during warmup, to ensure that everything is initialized before
starting to hunt reference leaks.

Other changes:

* Replace gc.collect() with support.gc_collect()
* Move calls to read memory statistics from dash_R_cleanup() to
  dash_R()
* Pass regrtest 'ns' to dash_R()
* dash_R() is now more quiet with --quiet option (don't display
  progress).
* Precompute the full range for "for it in range(repcount):" to
  ensure that the iteration doesn't allocate anything new.
* dash_R() now is responsible to call warm_caches().

(cherry picked from commit 5aaac94)
@vstinner
bpo-36560: regrtest: don't collect the GC twice (GH-12747)
fe04e5b 
dash_R() function of libregrtest doesn't call support.gc_collect()
directly anymore: it's already called by dash_R_cleanup().

Call dash_R_cleanup() before starting the loop.

(cherry picked from commit bb44478)
@vstinner vstinner merged commit 86f0354 into python:3.7 Apr 9, 2019
@vstinner vstinner deleted the regrtest37 branch April 9, 2019 16:55
@vstinner vstinner mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot