Skip to content

Fix Unicode encode_wstr_utf8() #127420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

vstinner
Copy link
Member

Raise RuntimeError instead of RuntimeWarning.

Raise RuntimeError instead of RuntimeWarning.
@vstinner
Copy link
Member Author

Issue spotted indirectly at: #127338 (comment)

Copy link
Contributor

@rruuaanng rruuaanng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit bf21e21 into python:main Dec 2, 2024
49 checks passed
@vstinner vstinner deleted the encode_wstr_utf8 branch December 2, 2024 10:14
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bf21e2160d1dc6869fb230b90a23ab030835395b 3.13

@miss-islington-app
Copy link

Sorry, @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker bf21e2160d1dc6869fb230b90a23ab030835395b 3.12

@picnixz
Copy link
Member

picnixz commented Dec 2, 2024

I can take care of the backports.

@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127504 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 2, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127505 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 2, 2024
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 2, 2024
Raise RuntimeError instead of RuntimeWarning.
vstinner added a commit that referenced this pull request Dec 2, 2024
Fix Unicode encode_wstr_utf8() (#127420)

Raise RuntimeError instead of RuntimeWarning.

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Dec 2, 2024
Fix Unicode encode_wstr_utf8() (#127420)

Raise RuntimeError instead of RuntimeWarning.

Co-authored-by: Victor Stinner <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
Raise RuntimeError instead of RuntimeWarning.
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Raise RuntimeError instead of RuntimeWarning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants