-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-126357: Remove gettext import guards #126358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this affect other implementations like PyPy?
I don't know enough about PyPy to be able to answer that :/ Do you know how I could verify that? |
You can take a look at the source code (https://github.com/pypy/pypy prefered way) or ping one of PyPy maintainers :) I suspect that it won't, but just to be sure. |
Ok so I applied this patch to the vendored stdlib in PyPy and built pypy3.11 without any issues. Importing these modules at runtime does not cause any issues either so I think it should be fine. The 4 buildbot failures also seem unrelated to this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM then! Thanks for checking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think that if there are some bootstrapping issues with the |
gettext
ingetopt
andoptparse
#126357