Skip to content

GH-124985: Document that pathlib.Path.copy() uses copy-on-write. #125861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Oct 22, 2024

@barneygale
Copy link
Contributor Author

@opk12 how does this look?

@opk12
Copy link

opk12 commented Oct 23, 2024

Thank you! Note for the future myself, the call chain is Path.copy() -> Path._copy_file() -> _os.copyfileobj() which does EAFP around FICLONE.

@barneygale barneygale requested a review from AA-Turner October 27, 2024 18:36
@barneygale barneygale requested a review from hugovk November 4, 2024 20:38
@barneygale
Copy link
Contributor Author

Thanks for the reviews, all!

@barneygale barneygale merged commit ff83499 into python:main Nov 5, 2024
33 checks passed
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news topic-pathlib
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants