Skip to content

Doc: Fix typos #125728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Doc: Fix typos #125728

merged 1 commit into from
Oct 21, 2024

Conversation

ember91
Copy link
Contributor

@ember91 ember91 commented Oct 19, 2024

@bedevere-app
Copy link

bedevere-app bot commented Oct 19, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@skirpichev
Copy link
Contributor

This affects also C sources.

@AA-Turner
Copy link
Member

@ember91 please revert all changes to Modules/

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes to Modules/

@bedevere-app
Copy link

bedevere-app bot commented Oct 19, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@bedevere-app
Copy link

bedevere-app bot commented Oct 19, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@ember91
Copy link
Contributor Author

ember91 commented Oct 19, 2024

Please revert all changes to Modules/

Done. No idea how that happened.

@ember91
Copy link
Contributor Author

ember91 commented Oct 19, 2024

This affects also C sources.

Fixed, by reverting changes to Modules/

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for correcting this PR. @AA-Turner this PR now addresses changes to .rst files.

@ember91 I encourage you to choose an open issue for a future PR and expanding beyond typo fixes. Thanks!

@willingc willingc added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 19, 2024
@erlend-aasland erlend-aasland dismissed AA-Turner’s stale review October 21, 2024 08:43

All changes to Modules/ have been reverted, as per Adam's request.

@erlend-aasland erlend-aasland changed the title Doc: Fix typos in Doc/ Doc: Fix typos Oct 21, 2024
@erlend-aasland erlend-aasland merged commit ded105a into python:main Oct 21, 2024
26 of 29 checks passed
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2024
(cherry picked from commit ded105a)

Co-authored-by: ember91 <[email protected]>
@miss-islington-app

This comment was marked as outdated.

@bedevere-app
Copy link

bedevere-app bot commented Oct 21, 2024

GH-125773 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 21, 2024
erlend-aasland pushed a commit that referenced this pull request Oct 21, 2024
(cherry picked from commit ded105a)

Co-authored-by: ember91 <[email protected]>
@erlend-aasland erlend-aasland removed the needs backport to 3.12 only security fixes label Oct 21, 2024
@erlend-aasland
Copy link
Contributor

Sorry, @ember91 and @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict. Please backport using cherry_picker on command line.

Let's not bother with the 3.12 since it does not apply cleanly.

ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants