Skip to content

gh-125610: Fix STORE_ATTR_INSTANCE_VALUE specialization check #125612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Oct 16, 2024

The STORE_ATTR_INSTANCE_VALUE opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.

The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with
non-NULL managed dictionaries, so don't specialize to that op in that case.
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should save a few repeated deopts.

I've one suggestion

@markshannon
Copy link
Member

markshannon commented Oct 24, 2024

The stats show the expected reduction in misses for STORE_ATTR_INSTANCE_VALUE

Co-authored-by: Mark Shannon <[email protected]>
@colesbury colesbury requested a review from markshannon October 24, 2024 13:20
@colesbury colesbury merged commit a353455 into python:main Dec 6, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesbury colesbury deleted the gh-125610-STORE_ATTR_INSTANCE_VALUE branch December 6, 2024 15:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 6, 2024
…pythonGH-125612)

The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with
non-NULL managed dictionaries, so don't specialize to that op in that case.
(cherry picked from commit a353455)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 6, 2024

GH-127698 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 6, 2024
colesbury added a commit that referenced this pull request Dec 6, 2024
GH-125612) (GH-127698)

The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with
non-NULL managed dictionaries, so don't specialize to that op in that case.
(cherry picked from commit a353455)

Co-authored-by: Sam Gross <[email protected]>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
…pythonGH-125612)

The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with
non-NULL managed dictionaries, so don't specialize to that op in that case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants