-
-
Notifications
You must be signed in to change notification settings - Fork 32k
gh-125610: Fix STORE_ATTR_INSTANCE_VALUE
specialization check
#125612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-125610: Fix STORE_ATTR_INSTANCE_VALUE
specialization check
#125612
Conversation
The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should save a few repeated deopts.
I've one suggestion
The stats show the expected reduction in misses for |
Co-authored-by: Mark Shannon <[email protected]>
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…pythonGH-125612) The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case. (cherry picked from commit a353455) Co-authored-by: Sam Gross <[email protected]>
GH-127698 is a backport of this pull request to the 3.13 branch. |
GH-125612) (GH-127698) The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case. (cherry picked from commit a353455) Co-authored-by: Sam Gross <[email protected]>
…pythonGH-125612) The `STORE_ATTR_INSTANCE_VALUE` opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.
The
STORE_ATTR_INSTANCE_VALUE
opcode doesn't support objects with non-NULL managed dictionaries, so don't specialize to that op in that case.STORE_ATTR_INSTANCE_VALUE
withobj.__dict__
#125610