Skip to content

gh-123290: fix a decref usage in _cursesmodule.c #124767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Sep 29, 2024

Using Py_DECREF on an object that could be NULL (my bad).

@picnixz picnixz changed the title gh-123961: fix a decref usage in _cursesmodule.c gh-123290: fix a decref usage in _cursesmodule.c Sep 29, 2024
@picnixz picnixz requested a review from vstinner September 29, 2024 14:32
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) September 29, 2024 14:33
@vstinner vstinner disabled auto-merge September 29, 2024 14:33
@vstinner vstinner enabled auto-merge (squash) September 29, 2024 14:34
@vstinner vstinner merged commit 12417a9 into python:main Sep 29, 2024
39 checks passed
@picnixz picnixz deleted the curses/fix-decref-on-null-123961 branch September 29, 2024 15:04
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.x has failed when building commit 12417a9.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/141) and take a look at the build logs.
  4. Check if the failure is related to this commit (12417a9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1594/builds/141

Failed tests:

  • test_os

Failed subtests:

  • test_timerfd_ns_poll - test.test_os.TimerfdTests.test_timerfd_ns_poll

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_os.py", line 4394, in test_timerfd_ns_poll
    self.check_timerfd_poll(True)
    ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "/data/user/0/org.python.testbed/files/python/lib/python3.14/test/test_os.py", line 4379, in check_timerfd_poll
    self.assertEqual(self.read_count_signaled(fd), 1)
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2 != 1

@mhsmith
Copy link
Member

mhsmith commented Oct 1, 2024

Buildbot failure is unrelated:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants