Skip to content

gh-124720: Update "Using Python on a Mac" document #124721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 29, 2024
Merged

gh-124720: Update "Using Python on a Mac" document #124721

merged 5 commits into from
Sep 29, 2024

Conversation

ned-deily
Copy link
Member

@ned-deily ned-deily commented Sep 28, 2024 •
edited by github-actions bot
Loading

Update "Using Python on a Mac" section of the "Python Setup and Usage" document and include information on installing free-threading support.

📚 Documentation preview 📚: https://cpython-previews--124721.org.readthedocs.build/

@ned-deily
pythongh-124720: Update "Using Python on a Mac" document
00a38bc 
Update "Using Python on a Mac" section of the "Python Setup and Usage"
document and include information on installing free-threading support.
@ned-deily ned-deily self-assigned this Sep 28, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 28, 2024
Closed
@zware
Copy link
Member

zware commented Sep 28, 2024

Some of these images are a bit bigger than they need to be; a quick search turned up picopt which is able to reduce the size of the images in Doc/using by 707 kB through optimization and metadata removal (python3.12 -m venv picopt_env; ./picopt_env/bin/pip install picopt; ./picopt_env/bin/picopt --png-max --strip-metadata --recurse Doc/using).

zware
zware reviewed Sep 28, 2024
View reviewed changes
Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good update! A few nits below.

freakboy3742
freakboy3742 requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a few minor things flagged inline. The 3.14 references are the biggest source of concern for me. I can see those easily getting confusing for 3.13 users, and they won't be automatically updated when 3.15 is released. That said, I also don't have any good ideas for how to automate the version substitution.

@bedevere-app
Copy link

bedevere-app bot commented Sep 28, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@ned-deily
Copy link
Member Author

Thanks for the thorough review comments! I believe I have addressed them. I would like to get this merged in for 3.13.0rc3 if at all possible.

I have made the requested changes; please review again.

@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2024

Thanks for making the requested changes!

@freakboy3742: please review the changes made to this pull request.

@bedevere-app bedevere-app bot requested a review from freakboy3742 September 29, 2024 22:35
freakboy3742
freakboy3742 approved these changes Sep 29, 2024
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 4b83c03 into python:main Sep 29, 2024
24 of 27 checks passed
@miss-islington-app
Copy link

Thanks @ned-deily for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 29, 2024
@ned-deily @miss-islington
pythongh-124720: Update "Using Python on a Mac" document (pythonGH-12…
688a4f3 
…4721)

Update "Using Python on a Mac" section of the "Python Setup and Usage"
document and include information on installing free-threading support.
(cherry picked from commit 4b83c03)

Co-authored-by: Ned Deily <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 29, 2024

GH-124775 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 29, 2024
Yhg1s pushed a commit that referenced this pull request Sep 30, 2024
@miss-islington @ned-deily
[3.13] gh-124720: Update "Using Python on a Mac" document (GH-124721) (…
7c7e01c 
…#124775)

gh-124720: Update "Using Python on a Mac" document (GH-124721)

Update "Using Python on a Mac" section of the "Python Setup and Usage"
document and include information on installing free-threading support.
(cherry picked from commit 4b83c03)

Co-authored-by: Ned Deily <[email protected]>
@ned-deily ned-deily deleted the gh-124720-update-using-mac-main branch February 20, 2025 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware left review comments

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@colesbury colesbury Awaiting requested review from colesbury

@ronaldoussoren ronaldoussoren Awaiting requested review from ronaldoussoren

Assignees

@ned-deily ned-deily

Labels
docs Documentation in the Doc dir OS-mac topic-free-threading topic-installation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ned-deily @zware @freakboy3742