Skip to content

gh-124476: Fix decode error by improving check_force_ascii function for NetBSD #124477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

gh-124476: Fix decode error by improving check_force_ascii function for NetBSD #124477

wants to merge 3 commits into from

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Sep 24, 2024 •
edited by bedevere-app bot
Loading

@furkanonder furkanonder added type-bug An unexpected behavior, bug, or error skip news 3.14 bugs and security fixes labels Sep 24, 2024
@bedevere-app bedevere-app bot mentioned this pull request Sep 24, 2024
Closed
@rruuaanng
Copy link
Contributor

rruuaanng commented Sep 25, 2024 •
edited
Loading

Maybe you should watch why do test_importlib.py build failed, And to change it.

@serhiy-storchaka
Copy link
Member

See also #132477.

Surprise, the last three digits of the alternate PR are the same.

vstinner
vstinner reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to avoid this change if possible, if #132477 fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
3.14 bugs and security fixes awaiting review OS-netbsd skip news type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@furkanonder @rruuaanng @serhiy-storchaka @vstinner