Skip to content

bpo-31904: fix test_utf8_mode fail issue on VxWorks #12428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2019
Merged

bpo-31904: fix test_utf8_mode fail issue on VxWorks #12428

merged 3 commits into from
Mar 27, 2019

Conversation

hliu0
Copy link
Contributor

@hliu0 hliu0 commented Mar 19, 2019 •
edited
Loading

VxWorks uses UTF-8 as the system encoding. So the test case test_utf8_mode.py need to be updated to use UTF-8 on VxWorks.

https://bugs.python.org/issue31904

@hliu0
bpo-31904: fix test_utf8_mode fail issue on VxWorks
5fedc23 
VxWorks uses UTF-8 as the system encoding.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Mar 19, 2019
vstinner
vstinner requested changes Mar 26, 2019
View reviewed changes
Lib/test/test_utf8_mode.py Outdated
@@ -12,7 +12,7 @@

MS_WINDOWS = (sys.platform == 'win32')
POSIX_LOCALES = ('C', 'POSIX')

_vxworks = (sys.platform == "vxworks")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the constant to VXWORKS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again

Misc/NEWS.d/next/Tests/2019-03-19-17-39-25.bpo-31904.QxhhRx.rst Outdated
@@ -0,0 +1,2 @@
VxWorks uses UTF-8 as the system encoding. So the test case test_utf8_mode.py
need to be updated to use UTF-8 on VxWorks.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose:

Fix test_utf8_mode on VxWorks: Python always use UTF-8 on VxWorks .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the requested changes; please review again

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@hliu0
bpo-31904: fix test_utf8_mode fail issue on VxWorks
df7d5d4 
Replace _vxworks with VXWORKS for VxWorks
@vstinner vstinner merged commit f4333d0 into python:master Mar 27, 2019
@pxinwr pxinwr deleted the fix-issue-31904-utf8-mode branch April 9, 2020 06:16
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hliu0 @bedevere-bot @vstinner @the-knights-who-say-ni