Skip to content

gh-124043: Disallow mixing --with-trace-refs and --disable-gil #124078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 16, 2024
Merged

gh-124043: Disallow mixing --with-trace-refs and --disable-gil #124078

merged 4 commits into from
Sep 16, 2024

Conversation

ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Sep 13, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 13, 2024
Closed
@ZeroIntensity ZeroIntensity marked this pull request as draft September 13, 2024 21:55
@ZeroIntensity
Copy link
Member Author

Marking as draft while I fix CI.

@ZeroIntensity ZeroIntensity marked this pull request as ready for review September 13, 2024 21:58
@Eclips4 Eclips4 requested a review from colesbury September 14, 2024 08:05
@Eclips4 Eclips4 added topic-free-threading build The build process and cross-build labels Sep 14, 2024
@Eclips4
Copy link
Member

Eclips4 commented Sep 15, 2024

LGTM. I'd prefer to backport it to 3.13 branch (we can wait until 3.13.1, this is not a big deal, IMO)

@Eclips4 Eclips4 added the needs backport to 3.13 bugs and security fixes label Sep 15, 2024
@colesbury
Copy link
Contributor

The PR is pretty small and straightforward, but If @erlend-aasland or @corona10 could take a look at this too, I'd appreciate it.

@colesbury colesbury merged commit 3b45df0 into python:main Sep 16, 2024
40 checks passed
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 16, 2024
@ZeroIntensity @miss-islington
pythongh-124043: Disallow mixing --with-trace-refs and `--disable-g…
fd6cfdf 
…il` (pythonGH-124078)

Tracing references is not currently thread-safe in the free-threaded build.
(cherry picked from commit 3b45df0)

Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Sep 16, 2024

GH-124138 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 16, 2024
savannahostrowski pushed a commit to savannahostrowski/cpython that referenced this pull request Sep 22, 2024
@ZeroIntensity @savannahostrowski
pythongh-124043: Disallow mixing --with-trace-refs and `--disable-g…
cc9d6b5 
…il` (python#124078)

Tracing references is not currently thread-safe in the free-threaded build.
@ZeroIntensity ZeroIntensity deleted the disallow-disable-gil-tracerefs branch September 23, 2024 22:49
Yhg1s pushed a commit that referenced this pull request Sep 24, 2024
@miss-islington @ZeroIntensity
[3.13] gh-124043: Disallow mixing --with-trace-refs and `--disable-…
8af2d18 
…gil` (GH-124078) (#124138)

gh-124043: Disallow mixing `--with-trace-refs` and `--disable-gil` (GH-124078)

Tracing references is not currently thread-safe in the free-threaded build.
(cherry picked from commit 3b45df0)

Co-authored-by: Peter Bierma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colesbury colesbury colesbury approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@Eclips4 Eclips4 Awaiting requested review from Eclips4

Assignees
No one assigned
Labels
build The build process and cross-build topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ZeroIntensity @Eclips4 @colesbury @erlend-aasland