-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
Mention curl
in contextvars
docs
#123838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention curl
in contextvars
docs
#123838
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
The only thing that puzzles me is here, check these two lines:
We declare HTTP/1.1 in response. Why do we need |
Alternatively, you can perhaps mention |
This is the first time I hear about |
Oh, |
Ok, I found the problem
Bot » curl 127.0.0.1:8081
Good bye, client @ ('127.0.0.1', 57051) » telnet 127.0.0.1 8081
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
HTTP/1.1 200 OK
Good bye, client @ ('127.0.0.1', 57046)
Connection closed by foreign host. @picnixz
|
If you feel it, maybe we can replace telnet by nc (there is a classic netcat and an OpenBSD one, namely |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
Thanks everyone! |
(cherry picked from commit b950831) Co-authored-by: sobolevn <[email protected]>
GH-123868 is a backport of this pull request to the 3.13 branch. |
(cherry picked from commit b950831) Co-authored-by: sobolevn <[email protected]>
GH-123869 is a backport of this pull request to the 3.12 branch. |
Mention `curl` in `contextvars` docs (GH-123838) (cherry picked from commit b950831) Co-authored-by: sobolevn <[email protected]>
Mention `curl` in `contextvars` docs (GH-123838) (cherry picked from commit b950831) Co-authored-by: sobolevn <[email protected]>
telnet
is rather rare in modern setups, I propose to also mentioncurl
usage, that 100% is present on most dev machines.Result:
Without
--http0.9
it will produce: