Skip to content

gh-121404: split compile.c into compile.c and codegen.c #123651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 9, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Sep 3, 2024

This is The Big Split.

In order to preserve as much git history as possible, I did a git mv Python/compile.c Python/codegen.c. Then I copied the compiler code from codegen.c to compile.c.

We end up with:

% wc -l Python/codegen.c Python/compile.c 
    6142 Python/codegen.c
    1665 Python/compile.c

So a complex file of 1.6K lines, and a relatively simple file with 6K lines.

@JelleZijlstra
Copy link
Member

FYI there are some compile errors (I'll do an actual review later)

@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Sep 3, 2024
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if the NO_LABEL entry in ignored.tsv for compile.c should be removed or not?

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, will leave remaining decisions on prefixes up to you.

@iritkatriel iritkatriel merged commit 1a9d891 into python:main Sep 9, 2024
35 checks passed
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants