-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-121404: split compile.c into compile.c and codegen.c #123651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI there are some compile errors (I'll do an actual review later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you check if the NO_LABEL
entry in ignored.tsv
for compile.c
should be removed or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, will leave remaining decisions on prefixes up to you.
This is The Big Split.
In order to preserve as much git history as possible, I did a
git mv Python/compile.c Python/codegen.c
. Then I copied the compiler code from codegen.c to compile.c.We end up with:
So a complex file of 1.6K lines, and a relatively simple file with 6K lines.