Skip to content

gh-121404: rearrange code in compile.c so that codegen functions come first and compiler functions second #123510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Aug 30, 2024

This PR mostly just moves code around. It places the codegen functions first and the compiler functions after.
The next step will be to move the compiler struct definition after codegen (a bit more tidying up is needed before that).
Also undefine the codegen macros before the compiler code. Then we will know that the two parts are independent, and can split them into two files.

Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too much moved code to review the whole diff -- I'm trusting that there aren't substantive changes, just rearrangement, and that tests pass unmodified. (If there are any areas of substantive change that you want looked into more carefully, please point them out!)

@iritkatriel
Copy link
Member Author

This is too much moved code to review the whole diff -- I'm trusting that there aren't substantive changes, just rearrangement, and that tests pass unmodified. (If there are any areas of substantive change that you want looked into more carefully, please point them out!)

Indeed there are no substantial changes in this PR. Thanks.

@iritkatriel iritkatriel merged commit 6bfbfc6 into python:main Aug 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants