gh-123370: Fix the canvas not clearing after running turtledemo.clock #123457

Wulian233 · 2024-08-29T04:36:32Z

In addition to fixing this bug, I also made some changes.

The second hand was shorter than the minute hand, which was incorrect, and this has now been fixed. (minute hand 130 → 115)
Remove the first line's coding: cp1252, as this file has always been utf8.

Issue: The canvas cannot be cleared after running turtledemo clock #123370

terryjreedy

Nice. Needs one change and one question answered. I also need to verify that we can remove functions. I suggested other changes on issue for other PR/issue.

Lib/turtledemo/clock.py

bedevere-app · 2024-08-31T02:52:44Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Lib/turtledemo/clock.py

Wulian233 · 2024-09-01T11:58:50Z

I have made the requested changes; please review again
The time is now dynamically updated, and the date is refreshed only once when the day changes. The cause of this bug is that the text was being refreshed every second 🚀 🕙

bandicam.2024-09-01.19-56-12-916.mp4

bedevere-app · 2024-09-01T11:58:55Z

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

Misc/NEWS.d/next/Library/2024-08-28-19-27-35.gh-issue-123370.SPZ9Ux.rst

Lib/turtledemo/clock.py

bedevere-app · 2024-09-04T06:24:25Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

…PZ9Ux.rst

Wulian233 · 2024-09-04T12:37:25Z

I have made the requested changes; please review again

Thank you for your review again. In the previous clock.py, the parameters used in the calls to the functions datum(z) and wochentag(t) were t = datetime.today(). These functions return the date (such as month, day, year) or the day of the week

https://github.com/python/cpython/blob/main/Lib/turtledemo/clock.py#L82-L93

https://github.com/python/cpython/blob/main/Lib/turtledemo/clock.py#L105-L105

Now wochentag and datum functions now ensure that the parameters and functionality are same (Because both use the datetime module)

def wochentag(t): 
     return t.strftime(format="%A") 
  
 def datum(z): 
     return z.strftime(format="%Y/%m/%d")

bedevere-app · 2024-09-04T12:37:32Z

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

terryjreedy · 2024-10-17T15:25:33Z

You reverted more than I requested, but moving the other changes, which I do want, to a separate cleanup/modernize backported PR is fine.

miss-islington-app · 2024-10-17T15:26:06Z

Thanks @Wulian233 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington-app · 2024-10-17T15:26:06Z

Thanks @Wulian233 for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2024-10-17T15:26:15Z

Sorry, @Wulian233 and @terryjreedy, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c124577ebe915a00de4033c0f7fa7c47621d79e0 3.12

miss-islington-app · 2024-10-17T15:26:32Z

Sorry, @Wulian233 and @terryjreedy, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker c124577ebe915a00de4033c0f7fa7c47621d79e0 3.13

…tledemo.clock (pythonGH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) Co-authored-by: Wulian <[email protected]>

terryjreedy · 2024-10-17T16:22:14Z

Merge conflict explained at #118673 (comment). This will impact (edit) docstring changes in the rest of turtledemo files. I have fixed this one for 3.13 and will backport that PR.

bedevere-app · 2024-10-17T16:22:53Z

GH-125653 is a backport of this pull request to the 3.13 branch.

…o.clock (gh-123457) (#125653) [3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clock (GH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) Co-authored-by: Wulian <[email protected]>

…tledemo.clock (pythongh-123457) (pythonGH-125653) [3.13] pythongh-123370: Fix the canvas not clearing after running turtledemo.clock (pythonGH-123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) (cherry picked from commit 30d7e9e) Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Wulian <[email protected]>

…rtledemo.clock (gh-123457) (GH-125653) (#125656) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change. (cherry picked from commit c124577) (cherry picked from commit 30d7e9e) Co-authored-by: Terry Jan Reedy <[email protected]> Co-authored-by: Wulian <[email protected]>

….clock (python#123457) Rewriting the day and date every tick somehow prevented them from being removed either by clicking STOP or loading another example. The solution is to rewrite them only when they change.

clock

a0b922f

bedevere-app bot mentioned this pull request Aug 29, 2024

The canvas cannot be cleared after running turtledemo clock #123370

Closed

bedevere-app bot added the awaiting review label Aug 29, 2024

picnixz requested a review from terryjreedy August 30, 2024 13:32

modern

a606e1b

terryjreedy requested changes Aug 31, 2024

View reviewed changes

Lib/turtledemo/clock.py Outdated Show resolved Hide resolved

Lib/turtledemo/clock.py Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting review labels Aug 31, 2024

terryjreedy reviewed Aug 31, 2024

View reviewed changes

Lib/turtledemo/clock.py Outdated Show resolved Hide resolved

dtfont

3be74cf

terryjreedy changed the title ~~gh-123370: Fix the canvas not clearing after running turtledemo clock and improve the clock example suite~~ gh-123370: Fix the canvas not clearing after running turtledemo.clock Aug 31, 2024

Wulian233 added 2 commits September 1, 2024 19:36

update time on day change

240d9ab

fix finish

dff3c3f

bedevere-app bot added awaiting change review and removed awaiting changes labels Sep 1, 2024

bedevere-app bot requested a review from terryjreedy September 1, 2024 11:58

terryjreedy requested changes Sep 4, 2024

View reviewed changes

Misc/NEWS.d/next/Library/2024-08-28-19-27-35.gh-issue-123370.SPZ9Ux.rst Outdated Show resolved Hide resolved

Lib/turtledemo/clock.py Show resolved Hide resolved

bedevere-app bot added awaiting changes and removed awaiting change review labels Sep 4, 2024

terryjreedy and others added 2 commits September 4, 2024 02:24

Update Misc/NEWS.d/next/Library/2024-08-28-19-27-35.gh-issue-123370.S…

9f76cd8

…PZ9Ux.rst

rename func

1ef646b

bedevere-app bot added awaiting change review and removed awaiting changes labels Sep 4, 2024

bedevere-app bot requested a review from terryjreedy September 4, 2024 12:37

terryjreedy approved these changes Oct 17, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting change review labels Oct 17, 2024

terryjreedy merged commit c124577 into python:main Oct 17, 2024
35 of 38 checks passed

bedevere-app bot removed the awaiting merge label Oct 17, 2024

terryjreedy added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Oct 17, 2024

miss-islington-app bot assigned terryjreedy Oct 17, 2024

terryjreedy added the type-bug An unexpected behavior, bug, or error label Oct 17, 2024

terryjreedy removed the type-bug An unexpected behavior, bug, or error label Oct 17, 2024

terryjreedy mentioned this pull request Oct 17, 2024

[3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clock (gh-123457) #125653

Merged

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 17, 2024

python deleted a comment from bedevere-app bot Oct 17, 2024

terryjreedy removed the needs backport to 3.12 only security fixes label Oct 17, 2024

miss-islington mentioned this pull request Oct 17, 2024

[3.12] [3.13] gh-123370: Fix the canvas not clearing after running turtledemo.clock (gh-123457) (GH-125653) #125656

Merged

Wulian233 deleted the clock branch October 17, 2024 22:22

Wulian233 mentioned this pull request Oct 17, 2024

Python turtledemo clock stop does not clear time #125187

Closed

terryjreedy mentioned this pull request Oct 20, 2024

gh-125665: Update turtledemo docstrings with correct file names #125691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

gh-123370: Fix the canvas not clearing after running turtledemo.clock #123457

gh-123370: Fix the canvas not clearing after running turtledemo.clock #123457

Wulian233 commented Aug 29, 2024 •

edited

Loading

terryjreedy left a comment

bedevere-app bot commented Aug 31, 2024

Wulian233 commented Sep 1, 2024 •

edited

Loading

bedevere-app bot commented Sep 1, 2024

bedevere-app bot commented Sep 4, 2024

Wulian233 commented Sep 4, 2024 •

edited

Loading

bedevere-app bot commented Sep 4, 2024

terryjreedy commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

terryjreedy commented Oct 17, 2024 •

edited

Loading

bedevere-app bot commented Oct 17, 2024

gh-123370: Fix the canvas not clearing after running turtledemo.clock #123457

gh-123370: Fix the canvas not clearing after running turtledemo.clock #123457

Conversation

Wulian233 commented Aug 29, 2024 • edited Loading

terryjreedy left a comment

Choose a reason for hiding this comment

bedevere-app bot commented Aug 31, 2024

Wulian233 commented Sep 1, 2024 • edited Loading

bedevere-app bot commented Sep 1, 2024

bedevere-app bot commented Sep 4, 2024

Wulian233 commented Sep 4, 2024 • edited Loading

bedevere-app bot commented Sep 4, 2024

terryjreedy commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

miss-islington-app bot commented Oct 17, 2024

terryjreedy commented Oct 17, 2024 • edited Loading

bedevere-app bot commented Oct 17, 2024

Wulian233 commented Aug 29, 2024 •

edited

Loading

Wulian233 commented Sep 1, 2024 •

edited

Loading

Wulian233 commented Sep 4, 2024 •

edited

Loading

terryjreedy commented Oct 17, 2024 •

edited

Loading