gh-123309: Remove check for redefined memo entry in pickletools.dis() #123374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
force-pushed
the
pickletools-dis-check-redefined-memo
branch
from
6fb72bb to
6a09abf
Compare
….dis() Such pickles are supported by the Unpickler even if the Pickler does not produce them.
serhiy-storchaka
force-pushed
the
pickletools-dis-check-redefined-memo
branch
from
6a09abf to
5f50e11
Compare
| @@ -2484,7 +2482,7 @@ def dis(pickle, out=None, memo=None, indentlevel=4, annotate=0): | |||
| assert opcode.name == "POP" | |||
| numtopop = 0 | |||
| else: | |||
| errormsg = markmsg = "no MARK exists on stack" | |||
| errormsg = "no MARK exists on stack" | |||
There was a problem hiding this comment.
I removed this because:
- this was the only case when the error message was also included in the output
- all other comments in the output are enclosed in parentheses, so this one was outlier
birkenfeld
approved these changes
Aug 31, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Such pickles are supported by the Unpickler even if the Pickler does not produce them.