-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-123149: Suppress verbose repr in new REPL #123151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally kept the f_in
and f_out
just for to know which file descriptor is being used but otherwise we can also suppress the entire fields.
Misc/NEWS.d/next/Library/2024-08-19-12-35-28.gh-issue-123149.7QbpJ4.rst
Outdated
Show resolved
Hide resolved
Before this patch, with
With this patch:
|
This reverts commit 199e785.
Good point, I'll tweak the changeset to suppress only the |
For now, let's keep your solution. I'd wait for @pablogsal's opinion on that matter. |
My bad, I committed faster than that comment. We'll see what Pablo thinks one way or the other :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Thanks @SnoopJ for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
(cherry picked from commit 833c58b) Co-authored-by: James <[email protected]>
GH-123157 is a backport of this pull request to the 3.13 branch. |
This changeset disables the automatic generation of a verbose (listing every registered field) repr for
_ReadlineWrapper
Fixes #123149.