Skip to content

Fix print usage in turtle doctests #122940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

sobolevn
Copy link
Member

No description provided.

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the turtle docstests running? As surely they should have been failing without this change...

A

@sobolevn
Copy link
Member Author

Nope, they are not real doctests, they just look like doctests. They are called examples in most cases. I think that this is fine, users can still benefit from it.

And I guess converting them to real doctests might be really hard.

@sobolevn sobolevn merged commit 901d949 into python:main Aug 13, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2024
(cherry picked from commit 901d949)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 13, 2024

GH-122977 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 13, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 13, 2024
(cherry picked from commit 901d949)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Aug 13, 2024

GH-122978 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Aug 13, 2024
sobolevn added a commit that referenced this pull request Aug 13, 2024
Fix `print` usage in `turtle` doctests (GH-122940)
(cherry picked from commit 901d949)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit that referenced this pull request Aug 13, 2024
Fix `print` usage in `turtle` doctests (GH-122940)
(cherry picked from commit 901d949)

Co-authored-by: sobolevn <[email protected]>
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants