Skip to content

GH-122869: Fix JIT build #122936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2024
Merged

GH-122869: Fix JIT build #122936

merged 2 commits into from
Aug 12, 2024

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Aug 12, 2024

Override automatically generated optimizer cases, to get build working.

@ZeroIntensity
Copy link
Member

Trying to build on this patch results in the following error:

/usr/bin/ld: Python/optimizer_analysis.o: in function `optimize_uops':
/home/zero/Projects/cpython/Python/optimizer_analysis.c:466:(.text+0x570c): undefined reference to `_Py_uop_abstractcontext_fini'
/usr/bin/ld: /home/zero/Projects/cpython/Python/optimizer_analysis.c:460:(.text+0x57e6): undefined reference to `_Py_uop_abstractcontext_fini'
/usr/bin/ld: /home/zero/Projects/cpython/Python/optimizer_analysis.c:483:(.text+0x5864): undefined reference to `_Py_uop_abstractcontext_fini'
/usr/bin/ld: Python/sysmodule.o: in function `sys__clear_internal_caches_impl':
/home/zero/Projects/cpython/./Python/sysmodule.c:2181:(.text+0x2d9c): undefined reference to `_Py_Executors_InvalidateAll'
/usr/bin/ld: Modules/_opcode.o: in function `_opcode_get_executor_impl':
/home/zero/Projects/cpython/./Modules/_opcode.c:392:(.text+0x3e6): undefined reference to `_Py_GetExecutor'

Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, forgot to make clean! Confirmed to fix my build problem from #122869

@brandtbucher brandtbucher merged commit 1795d6c into python:main Aug 12, 2024
53 of 55 checks passed
@brandtbucher brandtbucher changed the title GH-122869 Fix JIT build GH-122869: Fix JIT build Aug 12, 2024
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants