gh-122728: Fix SystemError in PyEval_GetLocals() #122735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PyEval_GetLocals() to avoid SystemError ("bad argument to
internal function"). Don't redefine the 'ret' variable in the if
block.
Add an unit test on PyEval_GetLocals().
|
Will test this in Fedora. |
|
Without the Python/ceval.c fix, the unit test reproduces the SystemError bug. |
hroncok
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
The change makes sense, is justified in the commit message, and fixes the problem in Fedora.
I have not verified the test fails without the fix, but I trust @vstinner that he has.
The test makes reasonable assertions and calls PyEval_GetLocals.
The news fragment is as detailed as needed.
gaogaotiantian
approved these changes
Aug 6, 2024
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 6, 2024
Fix PyEval_GetLocals() to avoid SystemError ("bad argument to
internal function"). Don't redefine the 'ret' variable in the if
block.
Add an unit test on PyEval_GetLocals().
(cherry picked from commit 4767a6e)
Co-authored-by: Victor Stinner <[email protected]>
|
GH-122757 is a backport of this pull request to the 3.13 branch. |
|
Many thanks for the quick fix and @hroncok for testing it too. Lovely to wake up to :) |
vstinner
added a commit
that referenced
this pull request
Aug 6, 2024
…122757) gh-122728: Fix SystemError in PyEval_GetLocals() (GH-122735) Fix PyEval_GetLocals() to avoid SystemError ("bad argument to internal function"). Don't redefine the 'ret' variable in the if block. Add an unit test on PyEval_GetLocals(). (cherry picked from commit 4767a6e) Co-authored-by: Victor Stinner <[email protected]>
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
Fix PyEval_GetLocals() to avoid SystemError ("bad argument to
internal function"). Don't redefine the 'ret' variable in the if
block.
Add an unit test on PyEval_GetLocals().
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
Fix PyEval_GetLocals() to avoid SystemError ("bad argument to
internal function"). Don't redefine the 'ret' variable in the if
block.
Add an unit test on PyEval_GetLocals().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PyEval_GetLocals() to avoid SystemError ("bad argument to internal function"). Don't redefine the 'ret' variable in the if block.
Add an unit test on PyEval_GetLocals().
SystemError: Objects/dictobject.c:3774: bad argument to internal function#122728