Skip to content

gh-112301: Add argument aliases and tee compiler output for check warnings #122465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

gh-112301: Add argument aliases and tee compiler output for check warnings #122465

merged 2 commits into from
Jul 30, 2024
+5 −2

Conversation

nohlson
Copy link
Contributor

@nohlson nohlson commented Jul 30, 2024 •
edited by bedevere-app bot
Loading

This adds argument aliases for the check_warnings.py script per suggestions: #121730 (comment)

Also includes re-adding compiler output to the build_ubuntu job log using tee as suggested: #121730 (comment)

@bedevere-app bedevere-app bot mentioned this pull request Jul 30, 2024
Open
@picnixz picnixz mentioned this pull request Jul 30, 2024
Merged
@picnixz
Copy link
Member

picnixz commented Jul 30, 2024 •
edited
Loading

Thank you for addressing my other review! do you want to address #121730 (comment) as well? (i.e. removing the shebang)?

(By the way, thanks for this tool; I was tired of doing it manually)

sethmlarson
sethmlarson approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, makes sense to try to land this one before the others since it impacts compiler outputs for core devs.

@nohlson
Copy link
Contributor Author

nohlson commented Jul 30, 2024

Thank you for addressing my other review! do you want to address #121730 (comment) as well? (i.e. removing the shebang)?

Removed shebang.

(By the way, thanks for this tool; I was tired of doing it manually)

No problem! I am curious what your use case is for running this tool yourself?

@zware zware merged commit 1cac090 into python:main Jul 30, 2024
34 checks passed
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@nohlson @blhsing
pythongh-112301: Add argument aliases and tee compiler output for che…
e7dffc7 
…ck warnings (pythonGH-122465)

Also remove superfluous shebang from the warning check script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@zware zware zware approved these changes

@sethmlarson sethmlarson sethmlarson approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nohlson @picnixz @zware @sethmlarson