GH-121832: Assert that the version number of static builtin types is not changed by PyType_Modified. #122182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by PyType_Modified. Update datetime module and a test to not call PyType_Modified.
markshannon
requested review from
pganssle,
abalkin and
JelleZijlstra
as code owners
markshannon
requested review from
ericsnowcurrently
and removed request for
abalkin,
JelleZijlstra and
pganssle
Co-authored-by: Bénédikt Tran <[email protected]>
|
Doesn't this need to be backported to 3.13? |
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
…es is not changed by PyType_Modified. (pythonGH-122182) Update datetime module and test_type_cache.py to not call PyType_Modified.
nohlson
pushed a commit
to nohlson/cpython
that referenced
this pull request
Jul 24, 2024
…es is not changed by PyType_Modified. (pythonGH-122182) Update datetime module and test_type_cache.py to not call PyType_Modified.
ericsnowcurrently
added
needs backport to 3.13
|
Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 25, 2024
…es is not changed by PyType_Modified. (pythonGH-122182) Update datetime module and test_type_cache.py to not call PyType_Modified. (cherry picked from commit e55b05f) Co-authored-by: Mark Shannon <[email protected]>
|
GH-122290 is a backport of this pull request to the 3.13 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update datetime module and test_type_cache.py to not call PyType_Modified.
--with-pydebugenabled #121832