Skip to content

[3.13] gh-121711: Set -m asyncio return_code to 1 for ENOTTY (GH-121714) #121718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2024
Merged

[3.13] gh-121711: Set -m asyncio return_code to 1 for ENOTTY (GH-121714) #121718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Lib/asyncio/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ def run(self):
if os.getenv("PYTHON_BASIC_REPL"):
raise RuntimeError("user environment requested basic REPL")
if not os.isatty(sys.stdin.fileno()):
raise OSError(errno.ENOTTY, "tty required", "stdin")
return_code = errno.ENOTTY
raise OSError(return_code, "tty required", "stdin")

# This import will fail on operating systems with no termios.
from _pyrepl.simple_interact import (
Expand Down
6 changes: 3 additions & 3 deletions Lib/test/test_repl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from textwrap import dedent
from test import support
from test.support import cpython_only, has_subprocess_support, SuppressCrashReport
from test.support.script_helper import kill_python, assert_python_ok
from test.support.script_helper import assert_python_failure, kill_python, assert_python_ok
from test.support.import_helper import import_module


Expand Down Expand Up @@ -195,8 +195,8 @@ def bar(x):
expected = "(30, None, [\'def foo(x):\\n\', \' return x + 1\\n\', \'\\n\'], \'<stdin>\')"
self.assertIn(expected, output, expected)

def test_asyncio_repl_is_ok(self):
assert_python_ok("-m", "asyncio")
def test_asyncio_repl_no_tty_fails(self):
assert assert_python_failure("-m", "asyncio")


class TestInteractiveModeSyntaxErrors(unittest.TestCase):
Expand Down
Loading