Skip to content

Add structure sizes to the _Py_DebugOffsets structure #121230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

P403n1x87
Copy link
Contributor

We add the size field to each of the structures referenced by the new _Py_DebugOffsets structure. This allows out-of-process tools to make a reduced number of system calls when resolving multiple fields from the same remote structures by making a local copy of the whole structure, and then using this to resolve the required fields.

We add the size field to each of the structures referenced by the new
_Py_DebugOffsets structure. This allows out-of-process tools to make a
reduced number of system calls when resolving multiple fields from the
same remote structures by making a local copy of the whole structure,
and then using this to resolve the required fields.
@P403n1x87
Copy link
Contributor Author

It would be great if this could be backported to 3.13.

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jul 2, 2024
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal: What do you think?

@pablogsal
Copy link
Member

Isn't this a duplicate of #120112 ?

@vstinner
Copy link
Member

vstinner commented Jul 2, 2024

Isn't this a duplicate of #120112 ?

Great minds think alike 😄

@P403n1x87
Copy link
Contributor Author

Ah, I didn't spot that one! I guess we can close this one then?

@pablogsal pablogsal closed this Jul 2, 2024
@pablogsal
Copy link
Member

Ah, I didn't spot that one! I guess we can close this one then?

Yep, let me land and back port that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants