Skip to content

bpo-31904: Add encoding support for VxWorks RTOS #12051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 4, 2019

Conversation

pxinwr
Copy link
Contributor

@pxinwr pxinwr commented Feb 26, 2019

This is the 2nd PR successively after #11968. This PR enables encoding support for VxWorks RTOS. More and full support on modules for VxWorks will continuously be added by the coming PRs.
VxWorks is a product developed and owned by Wind River. For VxWorks introduction or more details, go to https://www.windriver.com/products/vxworks/
Wind River will have a dedicated engineering team to contribute to the support as maintainers.
We already have a working buildbot worker internally, but has not bound to master. We will check the process for the buildbot, then add it.

https://bugs.python.org/issue31904

hliu0 and others added 3 commits February 26, 2019 17:25
The main reason are:
1. The locale is frequently misconfigured.
2. Missing some functions to deal with locale in VxWorks C library.
@vstinner
Copy link
Member

Please update the documentation, mention that VxWorks uses UTF-8:

@pxinwr
Copy link
Contributor Author

pxinwr commented Mar 1, 2019

@vstinner
The upstream has changed the location of the file coreconfig.h. This results in conflict. To facilitate the next merging, what is the proper action we need to do? Merging upstream codes down? Or close this PR, rebase my branch, fix the conflict then create a new PR?

@vstinner
Copy link
Member

vstinner commented Mar 1, 2019

Oh sorry, the conflict is my fault. Thanks for updating the doc. Please keep the same PR. Try to fix the conflict. Use for example "git merge master".

@vstinner
Copy link
Member

vstinner commented Mar 1, 2019

I'm the middle of a large refactoring work to enhance Python initialization:
https://bugs.python.org/issue36142 Sorry for the issues caused by these changes :-(

@pxinwr
Copy link
Contributor Author

pxinwr commented Mar 4, 2019

All right! We will use the same PR to fix the conflict soon.

@vstinner vstinner merged commit f4b0a1c into python:master Mar 4, 2019
@vstinner
Copy link
Member

vstinner commented Mar 4, 2019

I merged your PR, thanks.

It might be interesting to investigate why you have issues with locales on VxWorks, but I know that embedded devices don't really care of locales. Android had similar issues for years. But I'm fine with using UTF-8 on VxWorks.

@pxinwr
Copy link
Contributor Author

pxinwr commented Mar 5, 2019

Thanks for the comments associated with locale. Locale support is in our next plan. We will investigate this.

@vstinner
Copy link
Member

vstinner commented Mar 5, 2019

Thanks for the comments associated with locale. Locale support is in our next plan. We will investigate this.

Every platform has an "incomplete" support for locales. Each implementation makes its own choices: locale name, Unicode version, etc.

I wrote my own Python unit tests for locales, tests very specific to a platform, even for the platform version :-(
https://vstinner.readthedocs.io/unicode.html#test-non-ascii-characters-with-locales

I wrote an article on my recent work on Python code handling locales (bugfixes basically):
https://vstinner.github.io/locale-bugfixes-python3.html

I'm working on that for 10 years, and they are still bugs!

@pxinwr pxinwr deleted the fix-issue-31904-encodig branch July 12, 2021 09:42
@kuhlenough kuhlenough mannequin mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants