gh-119780: Adjust exception messages in Lib/test/test_format.py #119781
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Lib/test/test_format.py
Outdated
| @@ -82,6 +82,7 @@ def test_exc(formatstr, args, exception, excmsg): | |||
| else: | |||
| if verbose: print('no') | |||
| print('Unexpected ', exception, ':', repr(str(exc))) | |||
| raise | |||
There was a problem hiding this comment.
I suggest to remove this for now, and properly rewrite this function in a separate issue. This will help to backport it.
This is an ancient code which was ported to unittest. Now we can use subTest() if we want to see multiple failures.
There was a problem hiding this comment.
What is the issue with backporting this change? It should work fine on 3.12 too. We can rewrite this to properly use subTest() later, but this change is small and fixes a bug that led us to miss some real test failures.
There was a problem hiding this comment.
The code will be different in main and other branches, therefore conflicts, which should be resolved manually.
There was a problem hiding this comment.
@serhiy-storchaka, reverted. Issue description adjusted, so I don't think there should be a new issue.
…pythonGH-119781) Mismatches were just output to the stdout, without making the test failing.
…pythonGH-119781) Mismatches were just output to the stdout, without making the test failing.
Uh oh!
There was an error while loading. Please reload this page.