Uncomment one grammar test #118361
Merged
Uncomment one grammar test #118361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclips4
approved these changes
Apr 28, 2024
lysnikolaou
approved these changes
Apr 29, 2024
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 29, 2024
(cherry picked from commit 23d0371) Co-authored-by: Nikita Sobolev <[email protected]>
|
GH-118385 is a backport of this pull request to the 3.12 branch. |
sobolevn
added a commit
that referenced
this pull request
May 2, 2024
Uncomment one grammar test (GH-118361) (cherry picked from commit 23d0371) Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was commented for 18 years :)
Since https://github.com/python/cpython/blame/51aefc5bf907ddffaaf083ded0de773adcdf08c8/Lib/test/test_grammar.py#L167C19-L167C23
I don't see a point in keeping it commented. There are no other tests for floats with multiple starting zeros in this file. Let's enable it!