-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
gh-118216: Don't consider dotted __future__
imports
#118267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f0caedc
to
9adb811
Compare
Could you also configure pre-commit? https://devguide.python.org/getting-started/setup-building/#install-pre-commit
|
6f7bc77
to
bb766c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good. Could you add an entry to the What's New for 3.13? This is arguably a change to the language semantics.
Got it. |
bb766c7
to
9b908ee
Compare
@thatbirdguythatuknownot thanks! One piece of feedback: please avoid force-pushing to a PR branch, as it makes review somewhat harder. Just push a new commit and we'll squash them on merge. To update the PR branch with new commits from main, either click the "Update branch" button in GitHub or run |
Okay. |
Add checking for the number of dots before the module name alongside
__future__
name checks inPython/future.c
andPython/compile.c
. Basically makes a__future__
import only be considered one when no dots are present before the module name.__future__
imports allow dots before them #118216