Skip to content

gh-117977: Amend version changed annotation for os.chmod, os.chown, and os.listdir #117978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendo nineteendo commented Apr 17, 2024

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Apr 17, 2024
@nineteendo nineteendo marked this pull request as ready for review April 17, 2024 10:42
@nineteendo
Copy link
Contributor Author

nineteendo commented Apr 17, 2024

cc @hauntsaninja: happened here as well. Sorry for the ping.

@nineteendo
Copy link
Contributor Author

@erlend-aasland, could you merge this?

@erlend-aasland
Copy link
Contributor

Thanks!

@erlend-aasland erlend-aasland changed the title gh-117977: Fix os documentation gh-117977: Amend version changed annotation for os.chmod, os.chown, and os.listdir Apr 17, 2024
@erlend-aasland erlend-aasland enabled auto-merge (squash) April 17, 2024 14:57
@erlend-aasland
Copy link
Contributor

For future reference, try to make sure the PR title describes the actual change ;)

@erlend-aasland erlend-aasland merged commit fccedbd into python:main Apr 17, 2024
30 checks passed
@miss-islington-app
Copy link

Thanks @nineteendo for the PR, and @erlend-aasland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2024
…own, and os.listdir (pythonGH-117978)

(cherry picked from commit fccedbd)

Co-authored-by: Nice Zombies <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Apr 17, 2024

GH-117992 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Apr 17, 2024
@nineteendo nineteendo deleted the fix-os-docs branch April 17, 2024 15:05
erlend-aasland pushed a commit that referenced this pull request Apr 17, 2024
…hown, and os.listdir (GH-117978) (#117992)

(cherry picked from commit fccedbd)

Co-authored-by: Nice Zombies <[email protected]>
@nineteendo
Copy link
Contributor Author

Thanks, I wasn't sure how to describe this.

@hugovk
Copy link
Member

hugovk commented Apr 17, 2024

Merge branch 'main' into fix-os-docs

By the way, there's usually no need to update the PR from main unless you have a good reason (for example: merge conflict, there's something in main you need, or it's been a long time and you want to check it's still passing) because it uses up CI resources which can sometimes be rather limited.

Thanks!

@nineteendo
Copy link
Contributor Author

By the way, there's usually no need to update the PR from main unless you have a good reason

A required test randomly failed and you can't merge with failed tests. Is there a way to re-run a single test?

@hugovk
Copy link
Member

hugovk commented Apr 17, 2024

Not a single test, but a core dev (and maybe triager) can re-run a single failed job. But sounds like you had a good reason :)

Out of curiosity, which test randomly failed? I see a green tick next to the first commit.

@nineteendo
Copy link
Contributor Author

When the job gets cancelled by a new commit it doesn't seem to get saved. But I have the same problem here: #117855.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants