gh-117389: Fix test_compileall.EncodingTest
#117390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
added
skip news
needs backport to 3.11
vstinner
reviewed
Apr 2, 2024
|
I've addressed all your points, @vstinner! Agree with all of them. Please, take another look when you will have time. |
vstinner
approved these changes
May 5, 2024
| 'SyntaxError: bytes can only contain ASCII literal characters', | ||
| res, | ||
| ) | ||
| self.assertNotIn('UnicodeEncodeError', res) |
There was a problem hiding this comment.
I don't think that this check is useful.
There was a problem hiding this comment.
It was mentioned in #50965 (comment) so, I guess that it won't hurt.
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2024
(cherry picked from commit 44f6791) Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 5, 2024
(cherry picked from commit 44f6791) Co-authored-by: Nikita Sobolev <[email protected]>
|
backport to 3.11 is not needed anymore :( |
|
GH-118603 is a backport of this pull request to the 3.12 branch. |
|
GH-118604 is a backport of this pull request to the 3.11 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
coding, because we don't really need that anymore()toprintbytescannot contain unicode charscompile_dircall@vstinner can you please take a look? :)
test_compileall.EncodingTestis broken #117389