Skip to content

gh-115538: Remove PYTHONHOME's trailing slash in generated python.bat #117065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-115538: Remove PYTHONHOME's trailing slash in generated python.bat #117065

wants to merge 1 commit into from

Conversation

aisk
Copy link
Contributor

@aisk aisk commented Mar 20, 2024 •
edited by bedevere-app bot
Loading

@aisk aisk requested a review from a team as a code owner March 20, 2024 11:32
@bedevere-app bedevere-app bot mentioned this pull request Mar 20, 2024
Closed
@aisk aisk added the skip news label Mar 20, 2024
@zooba
Copy link
Member

zooba commented Mar 20, 2024

I can see how this will help the test, but I think we're better to make the test more robust.

@aisk
Copy link
Contributor Author

aisk commented Mar 20, 2024

Thanks for the review! I see the point, and I will create another PR soon.

@aisk aisk closed this Mar 20, 2024
@aisk aisk deleted the fix-test-venv branch March 20, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aisk @zooba