gh-116751: Inline _PyArg_CheckPositional() in Argument Clinic #116753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
erlend-aasland,
corona10,
ethanfurman,
rhettinger,
a team,
berkerpeksag,
gpshead,
brettcannon,
ericsnowcurrently,
ncoghlan,
warsaw,
serhiy-storchaka,
methane,
markshannon and
1st1
as code owners
* Compute "at least", "at most" and plural at build time (in Argument Clinic), rather than at runtime. * Don't format the function name in the format string to reduce the Python executable size, C compilers merge same format strings. * Make the generated code compatible with the limited C API. * Only clinic.py was modified manually, other changes are generated code.
vstinner
force-pushed
the
clinic_inline_check_positional
branch
from
6ac82d8 to
f8097eb
Compare
|
@serhiy-storchaka: Would you mind to review this change? |
|
See also PR #116736 |
|
Why not simply use the limited_capi code? |
serhiy-storchaka
removed request for
berkerpeksag,
gpshead,
ericsnowcurrently,
ncoghlan,
warsaw,
methane,
markshannon and
1st1
Would you mind to elaborate? |
|
Lines between |
Oh. Now I'm feeling stupid, I simply didn't see these lines... For my current use case, I will simply use the limited C API code path. I prefer to leave the clinic.py code unchanged for now, so I just close my PR :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.