GH-116596: Better determination of escaping uops. #116597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fidget-Spinner
approved these changes
Mar 11, 2024
gvanrossum
reviewed
Mar 11, 2024
| @@ -463,7 +463,7 @@ remove_unneeded_uops(_PyUOpInstruction *buffer, int buffer_size) | |||
| last->opcode == _COPY | |||
| ) { | |||
| last->opcode = _NOP; | |||
| buffer[pc].opcode = NOP; | |||
| buffer[pc].opcode = _NOP; | |||
There was a problem hiding this comment.
In Tier 1 it's NOP. In Tier 2 it's _NOP. The original code worked because they are currently the same value (as are all opcodes that are shared between T1 and T2). But eventually we may want all the Tier 2 opcodes to be distinct.
There was a problem hiding this comment.
Thanks for the clarification!
adorilson
pushed a commit
to adorilson/cpython
that referenced
this pull request
Mar 25, 2024
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any uop marked as escaping forces a
_SET_IPbefore it and a_CHECK_VALIDITYafterwards, which is expensive.This PR removes some false positives, where a uop is marked as escaping but does not.