Skip to content

gh-93502: Add new C-API functions to trace object creation and destruction #115945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 2, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Feb 26, 2024

@vstinner
Copy link
Member

@pablogsal: Sorry for late review, I missed your notification and then I lost it.

@pablogsal
Copy link
Member Author

@vstinner I addressed your feedback, do you mind taking a look before beta freeze?

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Here are some suggestions.

@@ -1904,6 +1904,52 @@ Python-level trace functions in previous versions.

.. versionadded:: 3.12

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to add a new section and just put the "versionadded:: 3.13" just after.

Example: "Reference Tracing".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pablogsal pablogsal merged commit 6bcbee0 into python:main May 2, 2024
36 checks passed
@pablogsal pablogsal deleted the tracerefs_interface branch May 2, 2024 17:30
SonicField pushed a commit to SonicField/cpython that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants