-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-93502: Add new C-API functions to trace object creation and destruction #115945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c975033
to
a7a7653
Compare
dacd932
to
ae9c004
Compare
@pablogsal: Sorry for late review, I missed your notification and then I lost it. |
Co-authored-by: Victor Stinner <[email protected]>
@vstinner I addressed your feedback, do you mind taking a look before beta freeze? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Here are some suggestions.
@@ -1904,6 +1904,52 @@ Python-level trace functions in previous versions. | |||
|
|||
.. versionadded:: 3.12 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to add a new section and just put the "versionadded:: 3.13" just after.
Example: "Reference Tracing".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Victor Stinner <[email protected]>
_Py_NewReference
for other tracers #93502