Skip to content

Fixes typo in asyncio.queue doc #11581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Fixes typo in asyncio.queue doc #11581

merged 1 commit into from
Jan 17, 2019

Conversation

0bsearch
Copy link
Contributor

Typo fix for method doc, I'm pretty sure coro is meant, because there's no consumer threads for thread-unsafe queue.

Most probably this piece of doc was copied from queue.Queue

There's not BPO bug for this, afaik.

@0bsearch 0bsearch requested a review from rhettinger as a code owner January 16, 2019 16:04
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 16, 2019
asvetlov
asvetlov approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov
Copy link
Contributor

Please sign a CLA.
CLA approval usually takes about 1 working day.

@0bsearch
Copy link
Contributor Author

CLA received, not sure if tag is removed automatically.

@miss-islington miss-islington merged commit 97e1299 into python:master Jan 17, 2019
@miss-islington
Copy link
Contributor

Thanks @3lnc for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@asvetlov
Copy link
Contributor

Thanks!

@bedevere-bot
Copy link

GH-11589 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 17, 2019
@0bsearch @miss-islington
Fixes typo in asyncio.queue doc (pythonGH-11581)
12ca343 
Typo fix for method doc, I'm pretty sure coro is meant, because there's no consumer threads for thread-unsafe queue.

Most probably this piece of doc was copied from `queue.Queue`

There's not BPO bug for this, afaik.
(cherry picked from commit 97e1299)

Co-authored-by: Slam <[email protected]>
miss-islington added a commit that referenced this pull request Jan 17, 2019
@miss-islington @0bsearch
Fixes typo in asyncio.queue doc (GH-11581)
6d84071 
Typo fix for method doc, I'm pretty sure coro is meant, because there's no consumer threads for thread-unsafe queue.

Most probably this piece of doc was copied from `queue.Queue`

There's not BPO bug for this, afaik.
(cherry picked from commit 97e1299)

Co-authored-by: Slam <[email protected]>
@0bsearch 0bsearch deleted the asyncio-doc-fix branch January 17, 2019 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0bsearch @the-knights-who-say-ni @asvetlov @miss-islington @bedevere-bot