-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-113445: amend PyObject_RichCompareBool() docs #113891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-113445: amend PyObject_RichCompareBool() docs #113891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it is better to to remove this sentence, and also replace the most of the description by the reference to PyObject_RichCompare()
. Only describe the difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit 926881d) Co-authored-by: Sergey B Kirpichev <[email protected]>
(cherry picked from commit 926881d) Co-authored-by: Sergey B Kirpichev <[email protected]>
GH-114637 is a backport of this pull request to the 3.11 branch. |
GH-114638 is a backport of this pull request to the 3.12 branch. |
…H-114638) (cherry picked from commit 926881d) Co-authored-by: Sergey B Kirpichev <[email protected]>
…H-114637) (cherry picked from commit 926881d) Co-authored-by: Sergey B Kirpichev <[email protected]>
📚 Documentation preview 📚: https://cpython-previews--113891.org.readthedocs.build/