Skip to content

Fix typo in socketserver docstring #11252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 21, 2018
Merged

Conversation

chrahunt
Copy link
Contributor

@chrahunt chrahunt commented Dec 20, 2018

Fix typo in the docstring of service_actions.
serve_forver -> serve_forever

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@Mariatta Mariatta changed the title Fix typo in documentation. Fix typo in socketserver docstring Dec 20, 2018
@Mariatta
Copy link
Member

Thanks for the PR. Please sign the CLA, and then the PR will be automatically be merged.

@miss-islington
Copy link
Contributor

Thanks @chrahunt for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-11281 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 21, 2018
Fix typo in the docstring of `service_actions`.
serve_forver -> serve_forever
(cherry picked from commit 6ded898)

Co-authored-by: Christopher Hunt <[email protected]>
@chrahunt chrahunt deleted the patch-1 branch December 21, 2018 22:28
miss-islington added a commit that referenced this pull request Dec 21, 2018
Fix typo in the docstring of `service_actions`.
serve_forver -> serve_forever
(cherry picked from commit 6ded898)

Co-authored-by: Christopher Hunt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants