Skip to content

gh-105323: Remove WITH_APPLE_EDITLINE to use the same declaration for all editline #112513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2023
Merged

gh-105323: Remove WITH_APPLE_EDITLINE to use the same declaration for all editline #112513

merged 3 commits into from
Dec 5, 2023

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantian gaogaotiantian commented Nov 29, 2023 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Nov 29, 2023
Closed
@corona10 corona10 self-assigned this Nov 29, 2023
@corona10
Copy link
Member

corona10 commented Nov 29, 2023 •
edited
Loading

I will think a little bit more about side effects from this change :)
Please give me time to this weekend.

@gaogaotiantian
Copy link
Member Author

No problem.

The readline/editline stuff in readline is a bit twisted. I believe at least as of now we never use the real editline.h. We use either readline/readline.h, which could be either from the real GNU readline or the "emulated" Mac libedit, or editline/readline.h, which is the compatible header from editline - it could be libedit-dev or some libedit om Mac.

WITH_EDITLINE does not make the situation clearer.

@corona10 corona10 merged commit e7e1116 into python:main Dec 5, 2023
@gaogaotiantian gaogaotiantian deleted the readline-editline branch December 5, 2023 21:20
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@gaogaotiantian @aisk
pythongh-105323: Remove WITH_APPLE_EDITLINE to use the same declara…
4549f3e 
…tion for all editline (pythongh-112513)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@gaogaotiantian @Glyphack
pythongh-105323: Remove WITH_APPLE_EDITLINE to use the same declara…
a73eb8e 
…tion for all editline (pythongh-112513)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees

@corona10 corona10

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaogaotiantian @corona10 @erlend-aasland