-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
GH-111485: Separate out parsing, analysis and code-gen phases #112299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 37 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
503f19a
Sort cases
markshannon be741bc
Reorganize code gen
markshannon 56e5001
Add type annotations
markshannon 3c35ba0
Various improvements to formatting
markshannon 59bdeca
Revert to declaration ordering of instructions
markshannon d41dfa5
Tweak formatting
markshannon efdcda1
Don't treat newline at end of '//' comment as part of the comment
markshannon f2d6a21
Add back static asserts
markshannon 2b593dc
Fix type annotation
markshannon 0a329a8
Use argparse and support multiple input files
markshannon 570d07a
Add support for line directives
markshannon bb18010
Tier 2 code gen. Work in progress
markshannon bbe3113
Merge branch 'main' into refactor-code-gen
markshannon bec93cf
Indent within parens to match the parens
markshannon 8481bea
Fix indenting
markshannon c91e61a
Fix indenting
markshannon f76160c
Remove surplus whitespace
markshannon ae2baea
Remove extra blank line
markshannon 92c9440
Attempt to placate MyPy
markshannon f9e41c6
Annotate false positives
markshannon ab2dbb3
Further attempts to make MyPy happy
markshannon 21a018b
Remove white space
markshannon 8078302
Fix newline and indentation handling
markshannon d5fcbed
Fix newline and indentation handling
markshannon 6c1ed31
A couple more type annotations
markshannon fc0f6ed
Fix alignment of comments
markshannon 39ebd6c
Avoid emitting blank lines
markshannon 7b21025
Further changes to keep MyPy happy
markshannon 796dcf6
Fix type annotation
markshannon 2272937
Correct previous 'fix'
markshannon 65b0c48
Fix type annotation
markshannon 0ce4dd2
Fix up multi-line comments
markshannon 54a727f
Tier 2 generator can wait for another PR
markshannon e0a4d35
Merge branch 'main' into refactor-code-gen
markshannon 9a81bbe
Don't use old case generator for tier 1
markshannon 28561cd
Avoid emitting unreachable code
markshannon 30f3015
Format new files with black
markshannon 5e01a73
Address review comments.
markshannon 6aacaca
Tidy
markshannon 19c9c1b
Add some explanatory comments
markshannon 8e385f5
Address review comments
markshannon bb6d42f
Rerun black
markshannon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.