Skip to content

gh-112243: Don't include comments in f-string debug expressions #112284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Nov 20, 2023

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments. Also, the lint job fails.

@pablogsal
Copy link
Member Author

@lysnikolaou fixed!

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good!

@pablogsal pablogsal merged commit d59feb5 into python:main Nov 20, 2023
@pablogsal pablogsal deleted the fstrings_debug branch November 20, 2023 15:18
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2023

GH-112285 is a backport of this pull request to the 3.12 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 20, 2023
…essions (pythonGH-112284)

(cherry picked from commit d59feb5)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
pablogsal added a commit that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants