Skip to content

[3.12] gh-111929: Fix regrtest --pgo: test_str => test_unicode #111938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2023
Merged

[3.12] gh-111929: Fix regrtest --pgo: test_str => test_unicode #111938

merged 1 commit into from
Nov 10, 2023

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Nov 10, 2023 •
edited by bedevere-app bot
Loading

test_unicode was renamed to test_str in Python 3.13, but Python 3.12 still uses test_unicode name.

@vstinner
pythongh-111929: Fix regrtest --pgo: test_str => test_unicode
7b9cd0e 
test_unicode was renamed to test_str in Python 3.13, but Python 3.12
still uses test_unicode name.
@bedevere-app bedevere-app bot mentioned this pull request Nov 10, 2023
Closed
@vstinner
Copy link
Member Author

Fix regression introduced by commit 80f9585.

@vstinner vstinner enabled auto-merge (squash) November 10, 2023 08:34
@vstinner vstinner added the needs backport to 3.11 only security fixes label Nov 10, 2023
@vstinner vstinner changed the title gh-111929: Fix regrtest --pgo: test_str => test_unicode [3.12) gh-111929: Fix regrtest --pgo: test_str => test_unicode Nov 10, 2023
@vstinner vstinner changed the title [3.12) gh-111929: Fix regrtest --pgo: test_str => test_unicode [3.12] gh-111929: Fix regrtest --pgo: test_str => test_unicode Nov 10, 2023
@vstinner vstinner merged commit 5f42a2b into python:3.12 Nov 10, 2023
@vstinner vstinner deleted the regrtest_pgo branch November 10, 2023 09:32
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2023
@vstinner @miss-islington
pythongh-111929: Fix regrtest --pgo: test_str => test_unicode (python…
3baa4b8 
…GH-111938)

test_unicode was renamed to test_str in Python 3.13, but Python 3.12
still uses test_unicode name.
(cherry picked from commit 5f42a2b)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Nov 10, 2023

GH-111940 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Nov 10, 2023
vstinner added a commit that referenced this pull request Nov 10, 2023
@miss-islington @vstinner
[3.11] gh-111929: Fix regrtest --pgo: test_str => test_unicode (GH-11…
ecc8df2 
…1938) (#111940)

gh-111929: Fix regrtest --pgo: test_str => test_unicode (GH-111938)

test_unicode was renamed to test_str in Python 3.13, but Python 3.12
still uses test_unicode name.
(cherry picked from commit 5f42a2b)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vstinner