GH-111804: Drop posix.fallocate() under WASI #111869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2.
brettcannon
added
needs backport to 3.11
|
!buildbot wasm32-wasi |
|
🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 077baab 🤖 The command will test the builders whose names match following regular expression: The builders matched are:
|
|
Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
Sorry, @brettcannon, I could not cleanly backport this to |
|
Sorry, @brettcannon, I could not cleanly backport this to |
|
The failure for the buildbot was due to an unrelated failure from 31c90d5 . |
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Nov 9, 2023
Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2. (cherry picked from commit 97c4c06)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Nov 9, 2023
Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2. (cherry picked from commit 97c4c06)
brettcannon
added a commit
to brettcannon/cpython
that referenced
this pull request
Nov 9, 2023
Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2.
|
GH-111919 is a backport of this pull request to the 3.12 branch. |
|
GH-111920 is a backport of this pull request to the 3.11 branch. |
brettcannon
added a commit
that referenced
this pull request
Nov 9, 2023
…11919) GH-111804: Drop posix.fallocate() under WASI (GH-111869) Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2.
brettcannon
added a commit
that referenced
this pull request
Nov 9, 2023
…11920) GH-111804: Drop posix.fallocate() under WASI (GH-111869) Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2.
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2.
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Drop posix.fallocate() under WASI. The underlying POSIX function, posix_fallocate(), was found to vary too much between implementations to remain in WASI. As such, while it was available in WASI preview1, it's been dropped in preview2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying POSIX function, posix_fallocate(), was found to vary too
much between implementations to remain in WASI. As such, while it was
available in WASI preview1, it's been dropped in preview2.
test_posix_fallocate()fails undertest_posixunder WASI #111804