Skip to content

gh-61199: Remove superfluous global statements from base64._b32{en,de}code()* #111785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

romuald
Copy link
Contributor

@romuald romuald commented Nov 6, 2023

Remove now useless "global" statements from the base32 encode / decode methods

None values where changed to a global dict by
4ce6faa

@ghost
Copy link

ghost commented Nov 6, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Remove now useless "global" statements from the base32 encode / decode
methods

None values where changed to a global dict by
4ce6faa
@romuald romuald force-pushed the wip-base64-useless-global branch from e07565c to 267abec Compare November 6, 2023 15:31
@gaogaotiantian
Copy link
Member

This may not need a separate issue, but a news entry would be good. You can use https://blurb-it.herokuapp.com/ to add news entry.

@zware zware changed the title Lib/base64.py: remove useless global statements gh-61199: Remove superfluous global statements from base64._b32{en,de}code()* Nov 7, 2023
@zware zware added the skip news label Nov 7, 2023
@zware zware requested review from pganssle and FFY00 November 7, 2023 18:37
@zware
Copy link
Member

zware commented Nov 7, 2023

No need for a NEWS entry, this should have literally no effect (though I'll leave it to @FFY00 and/or @pganssle to confirm that :) ).

@zware zware merged commit ea970fb into python:main Nov 7, 2023
hugovk pushed a commit to hugovk/cpython that referenced this pull request Nov 8, 2023
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants